implement windows support of the extension

browser_cli/cli.py

@@ -28,6 +28,7 @@ from browser_cli.client import (
     active_browser_targets,
     display_browser_name,
 )
+from browser_cli.platform import install_base_dir, is_windows
 
 console = Console()
 
@@ -56,6 +57,14 @@ NATIVE_HOST_DIRS = {
     },
 }
 
+WINDOWS_NATIVE_HOST_REGISTRY_KEYS = {
+    "chrome": [r"Software\Google\Chrome\NativeMessagingHosts"],
+    "chromium": [r"Software\Chromium\NativeMessagingHosts"],
+    "brave": [r"Software\BraveSoftware\Brave-Browser\NativeMessagingHosts"],
+    "edge": [r"Software\Microsoft\Edge\NativeMessagingHosts"],
+    "vivaldi": [r"Software\Vivaldi\NativeMessagingHosts"],
+}
+
 
 def _rename_target_profile(target_browser: str | None) -> str | None:
     if target_browser:
@@ -82,10 +91,9 @@ def _ensure_unique_browser_alias(alias: str, target_browser: str | None) -> None
 
 
 def _native_host_wrapper_path() -> Path:
-    if sys.platform == "darwin":
-        base_dir = Path.home() / "Library" / "Application Support" / "browser-cli"
-    else:
-        base_dir = Path(os.environ.get("XDG_DATA_HOME", Path.home() / ".local" / "share")) / "browser-cli"
+    base_dir = install_base_dir()
+    if is_windows():
+        return base_dir / "libexec" / "native-host.cmd"
     return base_dir / "libexec" / "native-host"
 
 
@@ -93,6 +101,30 @@ def _native_host_script_path() -> Path:
     return _native_host_wrapper_path().with_name("native_host.py")
 
 
+def _windows_registry_views():
+    import winreg
+
+    return [0, getattr(winreg, "KEY_WOW64_32KEY", 0), getattr(winreg, "KEY_WOW64_64KEY", 0)]
+
+
+def _register_windows_native_host(browser: str, manifest_path: Path) -> list[str]:
+    import winreg
+
+    installed = []
+    for key_path in WINDOWS_NATIVE_HOST_REGISTRY_KEYS[browser]:
+        full_key = f"{key_path}\\{NATIVE_HOST_NAME}"
+        for view in _windows_registry_views():
+            try:
+                access = winreg.KEY_WRITE | view
+                key = winreg.CreateKeyEx(winreg.HKEY_CURRENT_USER, full_key, 0, access)
+                with key:
+                    winreg.SetValueEx(key, "", 0, winreg.REG_SZ, str(manifest_path))
+                installed.append(f"HKCU\\{full_key}")
+            except OSError as e:
+                console.print(f"[yellow]Could not write registry key {full_key}: {e}[/yellow]")
+    return installed
+
+
 def _project_version() -> str:
     pyproject_path = Path(__file__).resolve().parent.parent / "pyproject.toml"
     try:
@@ -235,12 +267,16 @@ def cmd_install(browser):
     native_host_script_path = _native_host_script_path()
     wrapper_path.parent.mkdir(parents=True, exist_ok=True)
     shutil.copy2(Path(__file__).with_name("native_host.py"), native_host_script_path)
-    native_host_script_path.chmod(
-        native_host_script_path.stat().st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH
-    )
-    wrapper_content = f'#!/bin/sh\nexec "{sys.executable}" "{native_host_script_path}" "$@"\n'
-    wrapper_path.write_text(wrapper_content)
-    wrapper_path.chmod(wrapper_path.stat().st_mode | stat.S_IEXEC | stat.S_IXGRP | stat.S_IXOTH)
+    if not is_windows():
+        native_host_script_path.chmod(
+            native_host_script_path.stat().st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH
+        )
+        wrapper_content = f'#!/bin/sh\nexec "{sys.executable}" "{native_host_script_path}" "$@"\n'
+        wrapper_path.write_text(wrapper_content)
+        wrapper_path.chmod(wrapper_path.stat().st_mode | stat.S_IEXEC | stat.S_IXGRP | stat.S_IXOTH)
+    else:
+        wrapper_content = f'@echo off\r\n"{sys.executable}" "{native_host_script_path}" %*\r\n'
+        wrapper_path.write_text(wrapper_content, encoding="utf-8")
 
     # Ask for extension ID
     ext_urls = {
@@ -269,30 +305,41 @@ def cmd_install(browser):
         "allowed_origins": [f"chrome-extension://{extension_id}/"],
     }
 
-    # Write to OS native messaging dirs
-    platform = "darwin" if sys.platform == "darwin" else "linux"
-    dirs = NATIVE_HOST_DIRS[browser][platform]
-
     installed = []
-    for d in dirs:
-        try:
-            d.mkdir(parents=True, exist_ok=True)
-            manifest_path = d / f"{NATIVE_HOST_NAME}.json"
-            manifest_path.write_text(json.dumps(manifest, indent=2))
-            installed.append(manifest_path)
-        except Exception as e:
-            console.print(f"[yellow]Could not write to {d}: {e}[/yellow]")
+    if is_windows():
+        manifest_dir = wrapper_path.parent
+        manifest_dir.mkdir(parents=True, exist_ok=True)
+        manifest_path = manifest_dir / f"{NATIVE_HOST_NAME}.json"
+        manifest_path.write_text(json.dumps(manifest, indent=2), encoding="utf-8")
+        installed = _register_windows_native_host(browser, manifest_path)
+    else:
+        platform = "darwin" if sys.platform == "darwin" else "linux"
+        dirs = NATIVE_HOST_DIRS[browser][platform]
+
+        for d in dirs:
+            try:
+                d.mkdir(parents=True, exist_ok=True)
+                manifest_path = d / f"{NATIVE_HOST_NAME}.json"
+                manifest_path.write_text(json.dumps(manifest, indent=2))
+                installed.append(manifest_path)
+            except Exception as e:
+                console.print(f"[yellow]Could not write to {d}: {e}[/yellow]")
 
     if not installed:
         console.print("[red]Failed to install native host manifest[/red]")
         sys.exit(1)
 
     for p in installed:
-        console.print(f"[green]✓[/green] Wrote native host manifest: {p}")
+        if is_windows():
+            console.print(f"[green]✓[/green] Registered native host: {p}")
+        else:
+            console.print(f"[green]✓[/green] Wrote native host manifest: {p}")
     console.print(f"[green]✓[/green] Installed native host script: {native_host_script_path}")
     console.print(f"[green]✓[/green] Installed native host wrapper: {wrapper_path}")
+    if is_windows():
+        console.print("\n[green]✓[/green] Wrote native host manifest:", manifest_path)
 
-    console.print(f"\n[bold]Step 2:[/bold] Restart {browser.capitalize()} completely (Cmd/Ctrl+Q, then reopen)")
+    console.print(f"\n[bold]Step 2:[/bold] Restart {browser.capitalize()} completely (quit app, then reopen)")
     console.print("\n[green bold]✓ Installation complete![/green bold]")
     console.print("  After restarting the browser, try: [cyan]browser-cli tabs list[/cyan]")
 

browser_cli/client.py

@@ -1,11 +1,11 @@
 """
-Unix socket client — sends commands to the native host relay socket.
-Used by both the CLI and the public Python API.
+Local IPC client — sends commands to native host relay endpoint.
+Used by both CLI and public Python API.
 
 Profile selection order:
   1. Explicit `profile` argument to send_command()
   2. BROWSER_CLI_PROFILE environment variable
-  3. First entry in /tmp/.browser_cli/registry.json
+  3. First entry in runtime registry
   4. Otherwise, no browser can be resolved automatically
 """
 import json
@@ -14,11 +14,13 @@ import socket
 import struct
 import uuid
 from dataclasses import dataclass
+from multiprocessing.connection import Client as PipeClient
 from pathlib import Path
 from typing import Any
 
-SOCKET_DIR = Path("/tmp/.browser_cli")
-REGISTRY_PATH = SOCKET_DIR / "registry.json"
+from browser_cli.platform import endpoint_for_alias, is_windows, registry_path
+
+REGISTRY_PATH = registry_path()
 
 
 class BrowserNotConnected(Exception):
@@ -32,8 +34,10 @@ class BrowserTarget:
     socket_path: str
 
 
-def _active_sockets(reg: dict) -> dict:
-    """Return only entries whose socket file exists on disk."""
+def _active_endpoints(reg: dict) -> dict:
+    """Return only entries whose endpoint appears reachable."""
+    if is_windows():
+        return dict(reg)
     return {k: v for k, v in reg.items() if Path(v).exists()}
 
 
@@ -52,7 +56,7 @@ def active_browser_targets() -> list[BrowserTarget]:
         return []
     return [
         BrowserTarget(profile=profile, display_name=display_browser_name(profile, sock_path), socket_path=sock_path)
-        for profile, sock_path in _active_sockets(reg).items()
+        for profile, sock_path in _active_endpoints(reg).items()
     ]
 
 
@@ -68,8 +72,7 @@ def _resolve_socket(profile: str | None = None) -> str:
                     return reg[target]
             except Exception:
                 pass
-        safe = target.replace(" ", "_").replace("/", "_")
-        return str(SOCKET_DIR / f"{safe}.sock")
+        return endpoint_for_alias(target)
 
     # Auto-detect: error when multiple browser instances are active
     try:
@@ -107,10 +110,15 @@ def send_command(command: str, args: dict | None = None, profile: str | None = N
     framed = struct.pack("<I", len(payload)) + payload
 
     try:
-        with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as sock:
-            sock.connect(sock_path)
-            sock.sendall(framed)
-            response = _recv_all(sock)
+        if is_windows():
+            with PipeClient(sock_path, family="AF_PIPE") as conn:
+                conn.send_bytes(payload)
+                response = conn.recv_bytes()
+        else:
+            with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as sock:
+                sock.connect(sock_path)
+                sock.sendall(framed)
+                response = _recv_all(sock)
     except (FileNotFoundError, ConnectionRefusedError, OSError):
         profile_hint = f" (profile: {profile})" if profile else ""
         raise BrowserNotConnected(

browser_cli/native_host.py

@@ -2,13 +2,9 @@
 """
 Native Messaging Host for browser-cli.
 
-Chrome launches this process when the extension calls connectNative().
-It relays messages between the Chrome extension (via stdin/stdout using the
-Native Messaging protocol) and the CLI (via a Unix domain socket).
-
-Multi-browser support: the extension sends a "hello" message on startup
-with a profile alias. The host uses that alias to create a unique socket
-path and registers it in a shared registry file.
+Chrome launches this process when extension calls connectNative().
+It relays messages between extension (stdin/stdout Native Messaging protocol)
+and CLI (local IPC endpoint: Unix socket on Unix, named pipe on Windows).
 """
 import json
 import os
@@ -18,15 +14,15 @@ import struct
 import sys
 import threading
 import uuid
+from multiprocessing.connection import Listener
 from pathlib import Path
 
-SOCKET_DIR = Path("/tmp/.browser_cli")
-REGISTRY_PATH = SOCKET_DIR / "registry.json"
-DEFAULT_ALIAS = "default"
+from browser_cli.platform import DEFAULT_ALIAS, endpoint_for_alias, is_windows, registry_path, runtime_dir
 
 SOCKET_PATH: str = ""          # set after hello handshake
 PENDING: dict[str, queue.Queue] = {}
 PENDING_LOCK = threading.Lock()
+REGISTRY_PATH = registry_path()
 
 # --- Native Messaging protocol (4-byte LE length prefix + UTF-8 JSON) ---
 
@@ -71,8 +67,7 @@ def _registry_remove(alias: str) -> None:
 
 
 def _socket_path_for(alias: str) -> str:
-    safe = alias.replace(" ", "_").replace("/", "_")
-    return str(SOCKET_DIR / f"{safe}.sock")
+    return endpoint_for_alias(alias)
 
 
 def _resolve_profile_alias(first_msg: dict | None) -> str:
@@ -113,6 +108,16 @@ def stdin_reader(alias: str):
 # --- Thread B: accept CLI socket connections ---
 
 def socket_server(sock_path: str):
+    if is_windows():
+        while True:
+            try:
+                listener = Listener(sock_path, family="AF_PIPE")
+                conn = listener.accept()
+            except OSError:
+                break
+            threading.Thread(target=handle_cli_connection, args=(conn, listener), daemon=True).start()
+        return
+
     path = Path(sock_path)
     if path.exists():
         path.unlink()
@@ -126,12 +131,12 @@ def socket_server(sock_path: str):
             conn, _ = sock.accept()
         except OSError:
             break
-        threading.Thread(target=handle_cli_connection, args=(conn,), daemon=True).start()
+        threading.Thread(target=handle_cli_connection, args=(conn, None), daemon=True).start()
 
 
-def handle_cli_connection(conn: socket.socket) -> None:
+def handle_cli_connection(conn, listener=None) -> None:
     try:
-        data = _recv_all(conn)
+        data = conn.recv_bytes() if is_windows() else _recv_all(conn)
         if not data:
             return
         cmd = json.loads(data)
@@ -154,14 +159,24 @@ def handle_cli_connection(conn: socket.socket) -> None:
         with PENDING_LOCK:
             PENDING.pop(msg_id, None)
 
-        _send_all(conn, json.dumps(result).encode("utf-8"))
+        response = json.dumps(result).encode("utf-8")
+        if is_windows():
+            conn.send_bytes(response)
+        else:
+            _send_all(conn, response)
     except Exception as exc:
         try:
-            _send_all(conn, json.dumps({"success": False, "error": str(exc)}).encode("utf-8"))
+            response = json.dumps({"success": False, "error": str(exc)}).encode("utf-8")
+            if is_windows():
+                conn.send_bytes(response)
+            else:
+                _send_all(conn, response)
         except Exception:
             pass
     finally:
         conn.close()
+        if listener is not None:
+            listener.close()
 
 
 # --- Socket helpers (length-prefixed framing) ---
@@ -191,7 +206,8 @@ def _recv_exact(conn: socket.socket, n: int) -> bytes | None:
 
 def _cleanup(alias: str):
     try:
-        Path(_socket_path_for(alias)).unlink(missing_ok=True)
+        if not is_windows():
+            Path(_socket_path_for(alias)).unlink(missing_ok=True)
     except Exception:
         pass
     _registry_remove(alias)
@@ -215,7 +231,7 @@ def main():
                     PENDING[msg_id] = q
                 write_native_message(sys.stdout.buffer, first_msg)
 
-    SOCKET_DIR.mkdir(mode=0o700, exist_ok=True)
+    runtime_dir().mkdir(mode=0o700, exist_ok=True)
     sock_path = _socket_path_for(alias)
     _registry_add(alias, sock_path)
 

browser_cli/platform.py

@@ -0,0 +1,36 @@
+import os
+import sys
+from pathlib import Path
+
+APP_NAME = "browser-cli"
+RUNTIME_DIRNAME = ".browser_cli"
+DEFAULT_ALIAS = "default"
+
+def is_windows() -> bool:
+    return sys.platform.startswith("win")
+
+def runtime_dir() -> Path:
+    if is_windows():
+        base = Path(os.environ.get("LOCALAPPDATA", Path.home() / "AppData" / "Local"))
+        return base / APP_NAME
+    return Path("/tmp") / RUNTIME_DIRNAME
+
+def registry_path() -> Path:
+    return runtime_dir() / "registry.json"
+
+def install_base_dir() -> Path:
+    if is_windows():
+        return runtime_dir()
+    if sys.platform == "darwin":
+        return Path.home() / "Library" / "Application Support" / APP_NAME
+    return Path(os.environ.get("XDG_DATA_HOME", Path.home() / ".local" / "share")) / APP_NAME
+
+def sanitize_alias(alias:str) -> str:
+    cleaned = "".join(ch if ch.isalnum() or ch in "._-" else "_" for ch in alias.strip())
+    return cleaned or DEFAULT_ALIAS
+
+def endpoint_for_alias(alias:str) -> str:
+    safe = sanitize_alias(alias)
+    if is_windows():
+        return rf"\\.\pipe\browser-cli-{safe}"
+    return str(runtime_dir() / f"{safe}.sock")